Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(linux) Update debian images to bookworm #1687

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

timja
Copy link
Member

@timja timja commented Aug 17, 2023

Fixes #1686

Testing done

Built one of the images locally and checked it was using bookworm

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options
Loading

@timja timja requested review from ksalerno99 and a team as code owners August 17, 2023 07:44
@timja timja mentioned this pull request Aug 17, 2023
@timja timja requested a review from dduportal August 17, 2023 07:48
@dduportal dduportal changed the title Update to debian bookworm breaking(linux) Update debian images to bookworm Aug 17, 2023
@@ -1,5 +1,5 @@
ARG JAVA_VERSION="11.0.20_8"
ARG BULLSEYE_TAG=20230725
ARG BOOKWORM_TAG=20230725

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use a new tag, 20230814

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer!

That change will be applied automatically once merged thanks to the updatecli manifest.
It will prove that the automation system continue working as expected :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1688 => ✅ 🥳

@dduportal dduportal added breaking Breaking change debian labels Aug 17, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The usual CI checks are working as expected
  • Built locally and I have a working image for JDK17
  • Please note that the updatecli check is not required: it fails in the PR but should works once merged and we expect an automated PR which will update the debian version

@dduportal
Copy link
Contributor

@timja I'll let you merge once you're happy with the change / approval

@timja timja merged commit 9354844 into jenkinsci:master Aug 17, 2023
13 of 14 checks passed
@timja timja deleted the update-to-bookworm branch August 17, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Debian bookworm base image instead of bullseye to decrease unfixed vulnerability count
3 participants