Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Use updatecli to track JDK 11, 17 and 21 #1711

Merged
merged 23 commits into from Sep 25, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Sep 18, 2023

After @MarkEWaite's comment on PR #1707 (and the subsequent PR #1710), I am proposing three manifests to track the JDK versions. Specifically, I have created three updatecli manifests for JDK 11, 17, and 21.

This shouldn't be merged work until #1710 and #1712 are merged, and updatecli gets upgraded to version 0.61.0.

Testing done

updatecli diff --config ./updatecli/updatecli.d/jdk11.yaml --values ./updatecli/
values.github-action.yaml --debug
updatecli diff --config ./updatecli/updatecli.d/jdk17.yaml --values ./updatecli/
values.github-action.yaml --debug
updatecli diff --config ./updatecli/updatecli.d/jdk21.yaml --values ./updatecli/
values.github-action.yaml --debug

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar changed the title chore(dependencies): Updatecli manifests for java chore(dependencies): Updatecli manifests for JDK 11, 17 and 21. Sep 19, 2023
@gounthar gounthar marked this pull request as ready for review September 19, 2023 12:31
@gounthar gounthar requested review from ksalerno99 and a team as code owners September 19, 2023 12:31
gounthar and others added 2 commits September 19, 2023 16:28
@gounthar
Copy link
Contributor Author

Last build failed, but I'm not so sure it's my fault:

ERROR: failed to solve: process "/bin/sh -c curl -fsSL ${JENKINS_URL} -o /usr/share/jenkins/jenkins.war   && echo \"${JENKINS_SHA}  /usr/share/jenkins/jenkins.war\" >/tmp/jenkins_sha   && sha256sum -c --strict /tmp/jenkins_sha   && rm -f /tmp/jenkins_sha" did not complete successfully: exit code: 22
[1299](https://ci.jenkins.io/job/Packaging/job/docker/job/PR-1711/11/pipeline-console/?start-byte=296974&selected-node=858#log-1299)
script returned exit code 1

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updatecli manifests look really good.

But we have to, first, work on #1710 to avoid PR with double quotes 😅

Blocking until #1710 is merged and it is rebased (with conflict merges) here

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gounthar
Copy link
Contributor Author

gounthar commented Sep 24, 2023

Thank you Damien.

Strangely, I had done it in #1711...
That is corrected through #1720 .

@gounthar
Copy link
Contributor Author

Following this comment, I tried to remove the dependabot work about Java.

@dduportal
Copy link
Contributor

dduportal commented Sep 24, 2023

One last thing: as we discussed last week let's roll back the updatecli manifest to use ARG instead of FROM.

Rationale is that, even if the initial proposal to use FROM looked simpler, we want to use the Docker Bake to specify the JAVA_VERSION so ARG is mandatory.
The idea is to, like for agents, to Remove the ARG default value.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	0
  * Skipped:	0
  * Succeeded:	4
  * Total:	4

Nice work 👏

@dduportal dduportal changed the title chore(dependencies): Updatecli manifests for JDK 11, 17 and 21. chore(dependencies): Use updatecli to track JDK 11, 17 and 21 Sep 25, 2023
@dduportal dduportal merged commit 1d54116 into jenkinsci:master Sep 25, 2023
18 checks passed
@gounthar gounthar deleted the updatecli-for-java-manifests branch September 25, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants