Add timezone setting #777
Add timezone setting #777
Conversation
export TZ as an env variable Signed-off-by: Zhao Xiaojie <zxjlwt@126.com>
|
Looks interesting, but could you please see to add tests? Thanks! |
|
Do we have some documents about how to add tests? The manual test is ok. |
|
Thanks @LinuxSuRen ! |
There was a problem hiding this comment.
I am finally unconvinced this feature is needed to achieve TZ mapping.
Please provide a use case for this. I do not think the image is designed to be rebuilt, but more to be extended by users out there. And in the latter case, adding that TZ would not be usable through image inheritance.
| @@ -62,6 +62,10 @@ ENV JENKINS_UC_EXPERIMENTAL=https://updates.jenkins.io/experimental | |||
| ENV JENKINS_INCREMENTALS_REPO_MIRROR=https://repo.jenkins-ci.org/incrementals | |||
| RUN chown -R ${user} "$JENKINS_HOME" /usr/share/jenkins/ref | |||
|
|
|||
| # setting timezone | |||
| ENV TZ=UTC | |||
| RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | |||
There was a problem hiding this comment.
Also, I tend to think this is not how we should do this: using a RUN step, this means one has to rebuild the whole image to be able to adapt the TZ.
I did that in the past using the following mapping.
What does this PR provide that cannot be provided mapping the TZ file when executing docker run?
date
docker run jenkins/jenkins:lts date
docker run -v /usr/share/zoneinfo/CET:/etc/localtime jenkins/jenkins:lts date
Thu Dec 20 14:52:37 CET 2018
Thu Dec 20 13:52:37 UTC 2018
Thu Dec 20 14:52:38 CET 2018
There was a problem hiding this comment.
+1
I agree but I rather map the server's file /etc/localtime.
You should do this in docker-compose.yml
volumes:
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:roThere was a problem hiding this comment.
map for the timezone is a good solution. but it seams dependency the host os. What about other os, e.g. Window.
There was a problem hiding this comment.
I don't think it's in scope here, given we do not provide native Docker images for Windows, at least yet.
|
Going to close this given the discussion we had above. @LinuxSuRen please feel free to come and explain your use case, so we can reopen/consider this, but I really feel like the right path to handle timezones is #777 (comment) Having to rebuild the image to change the timezone seems much more complex than just mapping the right timezone file, which I think is also the correct way to do that in general, even apart from the context of the Jenkins Docker image. Thanks a lot for the contribution @LinuxSuRen, please keep them coming! ❤️ |
|
@batmat Yes, I just wish I could find a better solution to setting the timezone. The mapping way still is complex. |
|
I tend to disagree. At least, I could agree it's possibly a bit complex but still way less than rebuilding the whole image to change it :) |
|
I agree with that the rebuilding is bad. My expect way is that |
export TZ as an env variable