also update manually updated plugins if version in image is newer #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torstenwalter
force-pushed
the
always-update-plugins
branch
from
c5259eb
to
3068bb0
Compare
|
@batmat, @carlossg, @oleg-nenashev Could you please have a look at this? |
|
this was done on purpose to not break installations. You could add a flag to enable/disable the behavior |
|
I'll let others chime in if this should be the default |
|
Having the configuration option would also be fine, but at least having the option to decide would be great. So far we need to modify the script... |
|
Any update on this? Last comment here is 2 month ago and the alternative design #577 which enables this via variable is from 2017... |
|
Fixed in #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is no reason to stick to manually updated plugins ever if they are older than the currently installed ones then this PR could be used to simplify the code.
It would fix issue #790 which I raised. That issue contains a detailed explanation why I think this might be useful.