Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to SECURITY-170 #13

Merged
merged 2 commits into from
May 30, 2016
Merged

Adapt to SECURITY-170 #13

merged 2 commits into from
May 30, 2016

Conversation

rsandell
Copy link
Member

By using an EnvironmentContributor instead of build parameters

@reviewbybees

By using an EnvironmentContributor instead of build parameters
*/
@Deprecated
public Set<ParameterValue> getJobParamerers() {
if (Util.isOverridden(PushNotification.class, getClass(), "getRunParameters")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜 Minore code duplication

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

@oleg-nenashev
Copy link
Member

🐜 till the EnvironmentContributor becomes Restricted, 🐝 after it

@rsandell rsandell merged commit 6d2751f into master May 30, 2016
@rsandell rsandell deleted the sec-170-adaption branch May 30, 2016 16:22
@oleg-nenashev
Copy link
Member

@rsandell 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants