Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-67450 #86

Merged
merged 6 commits into from Feb 10, 2022
Merged

JENKINS-67450 #86

merged 6 commits into from Feb 10, 2022

Conversation

Zastai
Copy link
Contributor

@Zastai Zastai commented Feb 3, 2022 •
edited

Fix for JENKINS-64750.

This adds two new features:

  • a charset property on commands
    • this may help when the build issues localized messages
    • I could not reproduce the reported issue, so this might not work
  • an unstableIfErrors property on MSBuild commands
    • this causes build errors to mark the build as unstable instead of failed

@Zastai
Suppress warnings for unused methods
a14c133
@Zastai
Tweak JavaDoc style rules
a889e94
@Zastai
Add charset property to Command
afc1267
@Zastai
Add UI for the charset property of Command
9d0beca 
This also adds missing localisation for the "Require Specific SDK
Version" checkbox, and improves the French "execution failed" message.
@Zastai
Tweak JavaDoc
8fa2cea 
This mostly replaces "whether or not" with just "whether" (suggested
by IntelliJ).
@Zastai
Add an "unstable if error" option
0f3668d 
If a build completes with errors, the build will be set to unstable
instead of failed.

This does NOT affect cases where no errors are detected, but the return
code of the command is non-zero. That will always report the build as
failed.
@Zastai Zastai added the enhancement New feature or request label Feb 3, 2022
@Zastai Zastai merged commit 6f37785 into main Feb 10, 2022
@Zastai Zastai deleted the jenkins-67450 branch February 10, 2022 20:40
@Zastai Zastai added java Pull requests that update Java code minor A change that triggers a minor version bump labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request java Pull requests that update Java code minor A change that triggers a minor version bump
Projects
None yet
Milestone
No milestone
1 participant
@Zastai