Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22652] ConcurrentModificationException when Matrix project with... #3

Merged
merged 3 commits into from Dec 7, 2014

Conversation

or-shachar
Copy link

rebuild method should return final List and not changeable one.
When using multi-configuration concurrently the old way can cause concurrency issue, if list is changed while other thread is iterating over it.

@cloudbees-pull-request-builder

plugins » dynamic-axis-plugin #8 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

plugins » dynamic-axis-plugin #9 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

plugins » dynamic-axis-plugin #10 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@or-shachar
Copy link
Author

Is there an active reviewer that can merge this change in?

@oleg-nenashev oleg-nenashev added this to the 1.0.3 milestone Nov 18, 2014
@oleg-nenashev
Copy link
Member

LGTM. I'll merge and release it if there's no response from @kckane within 1 week

@oleg-nenashev
Copy link
Member

The fix also works on our production servers w/o any issues

oleg-nenashev added a commit that referenced this pull request Dec 7, 2014
[JENKINS-22652] ConcurrentModificationException when Matrix project with...
@oleg-nenashev oleg-nenashev merged commit 9db3d06 into jenkinsci:master Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants