Remove usages of com.google.common.base.Objects.firstNonNull
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @haugenj! Could this please be released? |
|
Yes I'll do this ASAP hopefully tomorrow |
|
Done! Apologies on the delay, I was hoping to get some other changes in as well but have been wrapped up in other projects :/ |
|
Thank you! I think this takes care of the most pressing Guava compatibility issue for this plugin (removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.google.common.base.Objects#firstNonNullhas been removed in recent versions of Guava, so consuming this API is a liability. This PR replaces usages ofcom.google.common.base.Objects#firstNonNullwith native Java functionality to allow this plugin to be used seamlessly with any version of Guava in the future.