Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #335 #388

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix #335 #388

merged 2 commits into from
Aug 23, 2023

Conversation

naraharip2017
Copy link
Collaborator

Handling following issue - #335.

Note that this is an improvement on the previous implementation for rescheduling failed builds, which would reschedule using the last build parameters, which may be different than the build that actually failed. However, this is not a catch all fix. If multiple builds fail, then a build may be re-scheduled with parameters of another failed build. Will open a separate issue to track further fixes that can be done here.

Testing done

Submitted build 1, changed build parameters and submitted build 2, terminated instance running build 1 and verified last failed build is set to build 1. Verified re-scheduled build uses parameters from build 1.

Tasks

No tasks being tracked yet.

@naraharip2017 naraharip2017 requested a review from pdk27 July 18, 2023 22:12
@naraharip2017 naraharip2017 self-assigned this Jul 18, 2023
@pdk27 pdk27 added the do not merge Don't merge this (at least not yet) label Jul 19, 2023
Copy link
Collaborator

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to cover this change?

Copy link
Collaborator

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pdk27 pdk27 merged commit efbed25 into master Aug 23, 2023
14 checks passed
@pdk27 pdk27 removed the do not merge Don't merge this (at least not yet) label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants