Issue 8617 #7
Closed
Issue 8617 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I think it makes more sense to put the config for this on the cloud, not the slave template. New pull request soon :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This branch adds the ability to have jenkins launch slaves into a particular security group (as per http://issues.jenkins-ci.org/browse/JENKINS-8617 ).
It's a bit more complicated than my last utterly trivial request. It was mostly cargo culted from https://github.com/ericNdfw/ec2-plugin/commit/97f826869d5273e1622c4fce3e5e06defc32b22f. Please advise of any style issues I've messed up on, I'm here to learn :-)
I have built & tested this change and it seems to work at least.
Cheers,
mwh