Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EC2 Placement Host Resource Group Arn parameter [JENKINS-66901] #784

Closed

Conversation

joneskoo
Copy link

@joneskoo joneskoo commented Nov 2, 2022

Implemented JENKINS-66901 parameter to set host resource group, to be used to dynamically allocate and release dedicated hosts, in particular for Mac instances.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I have manually tested the change works to successfully launch Mac instances, with or without host resource group set. I was not able to run the tests in my local environment and not sure how this could be meaningfully unit tested.

This is authored by me and copyright my employer WithSecure Corporation and I have permission to contribute it to the project under original license.

@joneskoo
Copy link
Author

joneskoo commented Nov 2, 2022

Ok so the tests broke, not a surprise since I wasn't able to get them to run even without any changes. I'll see if I figure out the problem and fix the tests.

@joneskoo
Copy link
Author

joneskoo commented Nov 7, 2022

See https://issues.jenkins.io/browse/JENKINS-66901 . There is a way to use Host Resource Group and License Manager without changes to EC2 plugin.

Otherwise would need to also add license configuration for License Manager, host resource group is not sufficient to launch.

@joneskoo joneskoo closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant