Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65261] Set echarts-build-trends library scope to provided #115

Merged
merged 2 commits into from Apr 7, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Apr 6, 2021

See https://issues.jenkins.io/browse/JENKINS-65261 for details.

  • Set echarts-build-trends scope to provided
  • Package eclipse-collections into plugin-util

@uhafner uhafner added the bug Bugs or performance problems label Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #115 (1462aba) into master (379cfd9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #115   +/-   ##
=========================================
  Coverage     72.97%   72.97%           
  Complexity        5        5           
=========================================
  Files             2        2           
  Lines            37       37           
  Branches          3        3           
=========================================
  Hits             27       27           
  Misses           10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379cfd9...1462aba. Read the comment docs.

@uhafner
Copy link
Member Author

uhafner commented Apr 7, 2021

I'll merge this PR even though a similar problem with eclipse-collections may occur. I'll let the JIRA issue open since the other fix requires a little bit more time.

@uhafner uhafner merged commit 7622c45 into master Apr 7, 2021
@uhafner uhafner deleted the make-echarts-build-trends-provided branch April 7, 2021 08:21
@KalleOlaviNiemitalo
Copy link

@uhafner, you didn't leave JENKINS-65261 open after all. Is there a separate issue that I could watch for the unification of eclipse-collections?

@uhafner
Copy link
Member Author

uhafner commented Apr 11, 2021

Well, I actually released analysis-model 10.0.0 today that does not require eclipse collections anymore. So I thought it would be safe to close the issue.

Additionally: libraries loaded by plugins are loaded with the class loader of the plugin. So it should be not a problem if the same library exists several times (it is the same version). If not, we still can reopen the ticket.

In this PR we had the problem that the same class existed twice in the same plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
2 participants