Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63770] Make trend charts configurable #124

Merged
merged 31 commits into from Jun 9, 2021
Merged

[JENKINS-63770] Make trend charts configurable #124

merged 31 commits into from Jun 9, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Apr 26, 2021

Replace previous build and date buttons inside of the chart with a configure button that provides a configuration of

  • number of builds to show
  • number of days to look into past
  • axis type (build label or date)

The selected configuration values will be saved in a browser's local storage.

Fixes JENKINS-63770.

Tasks:

Open points that need to be addressed in subsequent PRs:

  • Provide hierarchical configuration? (Jenkins->Folder->Job->User?)
  • Store configuration in user profile?

Screenshots

Trend chart with data-zoom in plugin view

Bildschirmfoto 2021-04-26 um 20 08 33

Build trend chart in jobs

Bildschirmfoto 2021-05-11 um 00 22 31
overview

Replace previous build and date buttons in chart with a configure button.
Fixes https://issues.jenkins.io/browse/JENKINS-63770.
Note: requires Bootstrap 5.
@uhafner uhafner added the enhancement Enhancement of existing functionality label Apr 26, 2021
@uhafner uhafner changed the title [JENKINS-63770] Make trend charts configurable [JENKINS-63770] Make zoomable trend chart configurable Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #124 (d7d9d56) into master (2805860) will decrease coverage by 8.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     72.97%   64.28%   -8.69%     
  Complexity        5        5              
============================================
  Files             2        3       +1     
  Lines            37       42       +5     
  Branches          3        3              
============================================
  Hits             27       27              
- Misses           10       15       +5     
Impacted Files Coverage Δ
...ugins/echarts/AsyncConfigurableTrendJobAction.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2805860...d7d9d56. Read the comment docs.

@uhafner uhafner marked this pull request as draft April 26, 2021 20:36
@uhafner uhafner changed the title [JENKINS-63770] Make zoomable trend chart configurable [JENKINS-63770] Make trend charts configurable May 10, 2021
Now the general trend options are changed for *all* charts.
So individual trend chart dialogs change the global configuration and the local one.
Now configuration of trend charts in job page and trend charts in details pages use a different dialog.
@uhafner uhafner marked this pull request as ready for review June 4, 2021 09:49
@uhafner uhafner merged commit 85494f2 into master Jun 9, 2021
@uhafner uhafner deleted the bootstrap5 branch June 9, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
1 participant