Fix spotbug findings #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,14 @@ abstract class AbstractTestBuilder implements Serializable { | |||
| this.context = context | |||
| } | |||
|
|
|||
| ExecutionConfig getExecutionConfig() { | |||
| return executionConfig? new ExecutionConfig(executionConfig) : null | |||
There was a problem hiding this comment.
format -> return executionConfig ? new ExecutionConfig(executionConfig) : null
and L51
| @@ -10,6 +10,7 @@ import hudson.Extension | |||
| import hudson.model.AbstractDescribableImpl | |||
| import hudson.model.Descriptor | |||
| import hudson.util.FormValidation | |||
| import org.apache.tools.ant.taskdefs.Exec | |||
| @@ -29,6 +29,11 @@ class Constant extends AbstractDescribableImpl<Constant> implements ExpandableCo | |||
| this.value = StringUtils.trimToEmpty(value) | |||
| } | |||
|
|
|||
| Constant(Constant constant) { | |||
There was a problem hiding this comment.
Couldn't we use the props and instantiate a new object instead of adding a new constructor
new Constant(oldConst.getLabel(), olConst.getValue)
Same for AdditionalSettings and *Configs
There was a problem hiding this comment.
We agreed on using copy constructors :)
Yes seems like its not possible to disable the scanning completly (even tried the task options). But issues found there, are not reported as there are exclude filters for those packages. |
MartinGroscheTT
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #64