Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65043] Use Jenkins 2.249.1 label verification #6

Merged
merged 16 commits into from
Mar 8, 2021
Merged

[JENKINS-65043] Use Jenkins 2.249.1 label verification #6

merged 16 commits into from
Mar 8, 2021

Conversation

MarkEWaite
Copy link
Collaborator

@MarkEWaite MarkEWaite commented Mar 7, 2021

JENKINS-65043 Use Jenkins 2.249.1 label verification methods

Use Jenkins 2.249.1 label validation methods to simplify the plugin code and improve the user experience. Aggregates multiple validations for better user presentation.

Also adds Mark Waite as a plugin maintainer, assuming that the request to adopt the plugin is approved.

Enables spotbugs for static analysis. Adds an equals and a hashCode method to fix a spotbugs warning. Adds a rudimentary test class that checks the equals method and some getters.

Enables release drafter and dependabot.

Switches to use the README as the plugin documentation.

Also cherry-picks the change from #5 into this pull request.

Screenshot

elastic-axis-aggregated-results

MarkEWaite and others added 16 commits March 6, 2021 13:37
Resolve test failure when updating to newer Jenkins base version
Ignore work dir and nbproject dir
Uses the Jenkins 2.249.1 bom for plugin dependencies.

Depends on the matrix-project plugin that was split from Jenkins core,

Enables spotbugs error checking with max effort and high threshold.

Switches label verification to use LabelExpression that was added in
Jenkins 2.249.1.  Aggregate validations for display to user

Log more about elastic axis behavior at FINEST

Remove unused AutoCompleteSeeder
@taksan taksan merged commit 2413b8b into jenkinsci:master Mar 8, 2021
@MarkEWaite MarkEWaite deleted the update-for-newer-jenkins branch March 8, 2021 13:10
timja pushed a commit to jenkins-infra/repository-permissions-updater that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants