-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65043] Use Jenkins 2.249.1 label verification #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve test failure when updating to newer Jenkins base version
Ignore work dir and nbproject dir
Uses the Jenkins 2.249.1 bom for plugin dependencies. Depends on the matrix-project plugin that was split from Jenkins core, Enables spotbugs error checking with max effort and high threshold. Switches label verification to use LabelExpression that was added in Jenkins 2.249.1. Aggregate validations for display to user Log more about elastic axis behavior at FINEST Remove unused AutoCompleteSeeder
Merged
9 tasks
timja
pushed a commit
to jenkins-infra/repository-permissions-updater
that referenced
this pull request
Mar 8, 2021
Approval from @taksan is visible in the Jenkins Developers list at https://groups.google.com/g/jenkinsci-dev/c/hpM-ML6CfzI/m/sTvK0t5fAQAJ jenkinsci/elastic-axis-plugin#6 is a recently merged pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-65043 Use Jenkins 2.249.1 label verification methods
Use Jenkins 2.249.1 label validation methods to simplify the plugin code and improve the user experience. Aggregates multiple validations for better user presentation.
Also adds Mark Waite as a plugin maintainer, assuming that the request to adopt the plugin is approved.
Enables spotbugs for static analysis. Adds an equals and a hashCode method to fix a spotbugs warning. Adds a rudimentary test class that checks the equals method and some getters.
Enables release drafter and dependabot.
Switches to use the README as the plugin documentation.
Also cherry-picks the change from #5 into this pull request.
Screenshot