Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert anonymous MasterToSlaveFileCallable to member #131

Merged
merged 1 commit into from Jul 7, 2018

Conversation

Projects
None yet
2 participants
@jsoref
Copy link
Contributor

jsoref commented Jul 6, 2018

org.jenkinsci.remoting.util.AnonymousClassWarnings warn:

WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader$1
WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.envinject.service.EnvInjectActionSetter$1

see: https://jenkins.io/redirect/serialization-of-anonymous-classes/

Convert anonymous MasterToSlaveFileCallable to member
org.jenkinsci.remoting.util.AnonymousClassWarnings warn:

WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader$1
WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.envinject.service.EnvInjectActionSetter$1

see: https://jenkins.io/redirect/serialization-of-anonymous-classes/
@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

I still think that converting this messages to WARNINGs by default was an overkill due to lots of false positives (CC @jglick @daniel-beck ).

This particular fix is fine, but it will be a never-ending story for plugin maintainers who were careful about serialization

@oleg-nenashev oleg-nenashev merged commit 502799f into jenkinsci:master Jul 7, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@jsoref jsoref deleted the jsoref:anonymous-mastertoslavecallable branch Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.