[JENKINS-68930] Fix Java17 Error on agent start #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED
NotMyFault
changed the title
NotMyFault
reviewed
Jul 5, 2022
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectMasterEnvVarsSetter.java
Outdated
Show resolved
Hide resolved
NotMyFault
changed the title
|
Untested, but looks good so far. Thanks for filing the PR! |
…tMasterEnvVarsSetter.java Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
oleg-nenashev
previously requested changes
Jul 5, 2022
|
Any chance to get this PR merged? |
NotMyFault
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Looks good, do you mind taking another look @oleg-nenashev ?
|
Can someone review the change request so this could possibly be merged? |
|
@oleg-nenashev Can you please review this so it can possible get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-66896 and JENKINS-68930
Use WA to work with modifiers field filtered since JDK12.
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED are required.