Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Groovy scripts and injecting environment variables after SCM #24

Merged
merged 1 commit into from May 28, 2014
Merged

Conversation

wenhao
Copy link
Contributor

@wenhao wenhao commented Nov 27, 2013

Currently, this plugin doesn't support Execute Groovy scripts after the SCM step in Build Wrapper.

added few lines to fix it.

@cloudbees-pull-request-builder

plugins » envinject-plugin #42 UNSTABLE
Looks like there's a problem with this pull request

@wenhao
Copy link
Contributor Author

wenhao commented Nov 27, 2013

Negative, #39 failed on Oct 13, 2013 with same error.

Also I run it on my local all good. I believe somebody need to look into it.

Thank you & Best Regards

Wen Hao(文浩)
Mail: wenhao@126.com
Skype: cdwenhao

On Nov 27, 2013, at 10:33 PM, CloudBees pull request builder plugin notifications@github.com wrote:

plugins » envinject-plugin #42 UNSTABLE
Looks like there's a problem with this pull request


Reply to this email directly or view it on GitHub.

@wenhao
Copy link
Contributor Author

wenhao commented Nov 27, 2013

Negative, #39 failed on Oct 13, 2013 with same error.

Also I run it on my local all good. I believe somebody need to look into it.

Thank you & Best Regards

Wen Hao(文浩)
Mail: wenhao@126.com
Skype: cdwenhao

On Nov 27, 2013, at 10:33 PM, CloudBees pull request builder plugin notifications@github.com wrote:

@oleg-nenashev
Copy link
Member

It makes sense to create an extension point (e.g. EnvInjectProducer) in order to add such features on-demand. Such extensive way is not good...

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

gboissinot added a commit that referenced this pull request May 28, 2014
Execute Groovy scripts and injecting environment variables after SCM
@gboissinot gboissinot merged commit e2ddbe9 into jenkinsci:master May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants