Skip to content

Commit

Permalink
closed #3 fixed the problem that specifying the building parameter fa…
Browse files Browse the repository at this point in the history
…ils when the choice is editable.

This is caused for the onsubmit of the form is broken. The combobox in Jenkins, that my editable choice is based on, seems to handle the onsubmit of the form in a little unappropriate way.
  • Loading branch information
ikedam committed Dec 29, 2012
1 parent f20dffd commit 66a0103
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pom.xml
Expand Up @@ -8,7 +8,7 @@

<groupId>jp.ikedam.jenkins.plugins</groupId>
<artifactId>extensible-choice-parameter</artifactId>
<version>0.11</version>
<version>0.1.2</version>
<packaging>hpi</packaging>
<name>Extensible Choice Parameter</name>
<url>http://dev.ikedam.jp/jenkins/extensible-choice-parameter/</url>
Expand Down
Expand Up @@ -59,7 +59,14 @@ Behaviour.specify("SELECT.staticCombobox", 'staticCombobox', 0, function(e) {
*/
e.oldonfocus = e.onfocus;
e.onfocus = function(e){
var oldonsubmit = this.form.onsubmit;
this.oldonfocus(e);
if(this.form.oldonsubmit != oldonsubmit){
// 一部のバージョンのJenkinsの不具合への対応。
// Comboboxでformの元のonsubmitを待避するタイミングが早すぎて、
// onsubmitの復元に失敗する。
this.form.oldonsubmit = oldonsubmit;
}
this.comboBox.valueChanged();
}
});

0 comments on commit 66a0103

Please sign in to comment.