Make it possible to submit a new external job per CLI

[davido]

With this command external job submission is possible per CLI.
Per pipe gzipped log file can be transported. No wrapper scripts are needed
it can be easily done from the command line:

cat log.gz | ssh jenkins set-external-build-result --job b --result 0 --log -

[buildhive]

Jenkins » external-monitor-job-plugin #16 SUCCESS
This pull request looks good
(what's this?)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[jglick]

Originally #2.

[davido]

Thanks, for fixing it! I need to adjust LibreOffice code. May be we can put that part from out buildbot-plugin code as JUnit or contrib example?

[davido]

I would extract that code and submit a pull request:

https://github.com/davido/gerrit-buildbot-plugin/blob/master/src/main/java/org/libreoffice/ci/gerrit/buildbot/publisher/JenkinsLogPublisher.java

[jglick]

Sorry, thought my comment was inserted twice so I deleted the second, but that was the only one.

Yes you can try taking code similar to that, and making it into a JenkinsRule-based test (use 1.480.3 parent POM). Just need to replace exitValue() with out to get build number.

[davido]

So we probably don't want to introduce the GIT dependency (URLish) to jenkins. I wonder how could i conduct a JUnit test for new introduce CLI command? I found these info:

https://wiki.jenkins-ci.org/display/JENKINS/Unit+Test
https://wiki.jenkins-ci.org/display/JENKINS/Extension+points
https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+CLI

but it is not obvious to me how to call CLI command from a standard JenkinsRule unit test. Any thoughts?

Thanks.

[davido]

Okay, found how to invoke CLI so far, With latest published parent pom 1.529 it seems to be really easy to do. I am getting NPE exception while trying to create ExternalJob instance. here is the code:

http://pastebin.com/ZCpJJ5y3

Any clue?

[davido]

Seems to be general problem with that version: Old style unit test doesn't work either:

public class ExternalRunTest extends HudsonTestCase {
public void test1() throws Exception {
ExternalJob p = hudson.createProject(ExternalJob.class, "test");

has the same NPE. With the parent pom version that you suggested 1.480.3 the old unit test seems to ork. However the new classes CLICommandInvoker are missing in this version. That why i was trying to make it work with new new one.

[davido]

Ok, bibisect helps: tried all version and it was broken in the version 1.512.
1.511 is the lat version it works. So would base my test on it. Unfortunately without CLICommandInvoker then ...

[davido]

Just uploaded a new pull request: CLI command is failing: argument parsing still broken. any ideas?

Thanks