New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-35244] Implement the exws step #6
Conversation
Retriggering the build |
@@ -76,6 +77,9 @@ public FormValidation doCheckName(@QueryParameter String value) { | |||
} | |||
|
|||
public FormValidation doCheckPhysicalPathOnDisk(@QueryParameter String value) { | |||
if (!isRelativePath(fixEmptyAndTrim(value))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringUtils.isBlank() is preferable
break; | ||
} | ||
} | ||
if (selectedTemplate != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could replace this line with an early return if (selectedTemplate == null) return null
, but no strong opinion here.
Thank you Alex! |
LGTM 👍 |
This branch was created against |
I'll do smaller commits from now on :)
CC @oleg-nenashev @martinda