Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use jcasc test harness #73

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Jan 17, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@alexsomai
Copy link
Member

Thanks, LGTM 👍

Q: The PCT release should be done before this one is merged, or it's not related?

@timja
Copy link
Member Author

timja commented Jan 18, 2020

Thanks, LGTM 👍

Q: The PCT release should be done before this one is merged, or it's not related?

This plugin released so that compatibility testing with this plugin works.

Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is PCT? Plugin Compatibility Test?

@timja
Copy link
Member Author

timja commented Jan 19, 2020

Yes

@alexsomai alexsomai merged commit 8f325c4 into jenkinsci:master Jan 19, 2020
@timja timja deleted the upgrade-jcasc branch January 19, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants