[JENKINS-70693] Call FilePathDynamicContext.createContextualObject(FilePath, FlowNode)
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
changed the title
FilePathDynamicContext.createContextualObject(FilePath, FlowNode)
6 tasks
timja
commented
Mar 4, 2023
bolt-alex-somai
approved these changes
Mar 5, 2023
|
Thank you, @timja, for handling this! I've tested it locally, and it works. Previously I was able to reproduce the issue. May I merge it? Also, now that incrementals are enabled for the plugin, do I have to do anything special to release it after the merge? A while ago, I used to run |
alexsomai
approved these changes
Mar 5, 2023
Incrementals changes nothing for release, if you want it to be automated you would have to follow: https://www.jenkins.io/doc/developer/publishing/releasing-cd/
Yes go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue [JENKINS-70693]
Verified in the acceptance test harness that this fixes the test failing there.
https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/ExternalWorkspaceManagerPluginTest.java
Alternative to #76