Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt icon removal from core and bump core requirement to 2.319.3 #72

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Feb 10, 2022

Fixes JENKINS-67176

The change proposed adapts the icon removal from core and bumps the base line to a modern version of Jenkins.
JSR 305 has been replaced with findbugs annotations, because it's EOL and the bom offers findbugs as replacement.

cc @olamy if you mind taking a look :)

Closes #68 as well


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira

@NotMyFault NotMyFault force-pushed the fix/master/fix-icons-on-modern-jenkins branch from 97b4c50 to e18326a Compare February 10, 2022 13:57
@NotMyFault NotMyFault force-pushed the fix/master/fix-icons-on-modern-jenkins branch from e18326a to 175a2de Compare February 10, 2022 14:05
@NotMyFault
Copy link
Member Author

ci.jenkins.io does not accept Jenkinsfile modifications from foreign PRs on the PR itself, hence the build fails, because it builds with 2.222 instead of 2.319.3.
However, tests are working fine, according to GitHub actions and to my local testing.
Do you mind giving it a review nevertheless, @olamy :)

@boczh
Copy link

boczh commented Feb 17, 2022

Hello, just wondering if there is any timeline on approximately when will this PR be merged and new plugin version released?

@NotMyFault
Copy link
Member Author

Hello, just wondering if there is any timeline on approximately when will this PR be merged and new plugin version released?

Anytime, once a maintainer reviews it. In the meantime, you can either build it yourself or use my build binaries: https://keybase.pub/notmyfault_og/jenkins/favorite-plugin/

@olamy olamy changed the title Adapt icon removal from core and bump baseline Adapt icon removal from core and bump core requirement to 2.319.3 Feb 26, 2022
@olamy olamy merged commit 6d3d16a into jenkinsci:master Feb 26, 2022
@olamy
Copy link
Member

olamy commented Feb 26, 2022

release done.
sorry guys for delay I have missed the ping (and notifications were lost in a huge stack :( )

@NotMyFault NotMyFault deleted the fix/master/fix-icons-on-modern-jenkins branch February 26, 2022 08:56
@NotMyFault
Copy link
Member Author

No worries, thanks for taking care of it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants