Simplify try/finally block

jenkinsci · Apr 11, 2018 · f92223d · f92223d
1 parent 3cc9fdc
commit f92223d
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/test/java/com/cloudbees/jenkins/plugins/file_leak_detector/FileHandleDumpTest.java b/src/test/java/com/cloudbees/jenkins/plugins/file_leak_detector/FileHandleDumpTest.java
@@ -73,9 +73,8 @@ public void detectFileLeak() throws Exception {
     @Test
     public void detectPipeLeak() throws Exception {
         activateFileLeakDetector();
-        Pipe p = null;
+        Pipe p = Pipe.open();
         try {
-            p = Pipe.open();
             assertThat("There should be a pipe sink and source channel opened by this method", getOpenDescriptors(), allOf(
                 hasItem(allOf(
                         containsString("Pipe Sink Channel by thread:"),
@@ -85,10 +84,8 @@ public void detectPipeLeak() throws Exception {
                         containsString("FileHandleDumpTest.detectPipeLeak(")
                 ))));
         } finally {
-            if (p != null) {
-                p.sink().close();
-                p.source().close();
-            }
+            p.sink().close();
+            p.source().close();
         }
         assertThat("There should not be a pipe sink or source channel opened by this method", getOpenDescriptors(), not(anyOf(
                 hasItem(allOf(