Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new detail view that shows info and error messages #365

Merged
merged 6 commits into from
Nov 20, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 17, 2021

This view has been copied from the warnings-ng plugin and is now available for all plugins that want to show information and error messages. This is a downstream PR for jenkinsci/bootstrap5-api-plugin#65.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #365 (b159481) into master (d0dc4ec) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #365      +/-   ##
============================================
+ Coverage     62.26%   62.29%   +0.03%     
- Complexity      289      290       +1     
============================================
  Files            41       41              
  Lines          1052     1053       +1     
  Branches         88       88              
============================================
+ Hits            655      656       +1     
  Misses          360      360              
  Partials         37       37              
Impacted Files Coverage Δ
...plugins/forensics/reference/ReferenceRecorder.java 71.26% <ø> (ø)
...ns/plugins/forensics/reference/ReferenceBuild.java 82.92% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dc4ec...b159481. Read the comment docs.

@uhafner uhafner merged commit 21eb86c into master Nov 20, 2021
@uhafner uhafner deleted the info-messages branch November 20, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
1 participant