Ignore case of email address when counting different authors in commits #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jagrutiti
commented
Jan 18, 2023
src/test/java/io/jenkins/plugins/forensics/miner/CommitStatisticsTest.java
Outdated
Show resolved
Hide resolved
uhafner
requested changes
Jan 18, 2023
src/main/java/io/jenkins/plugins/forensics/miner/CommitStatistics.java
Outdated
Show resolved
Hide resolved
…ics.java Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
Jagrutiti
commented
Jan 18, 2023
| @@ -132,7 +132,7 @@ public String toString() { | |||
|
|
|||
| private static int getDistinctCount(final Collection<? extends CommitDiffItem> commits, | |||
| final Function<CommitDiffItem, String> property) { | |||
| return (int) commits.stream().map(property).map(s -> String.toLowerCase(Locale.ENGLISH)).distinct().count(); | |||
There was a problem hiding this comment.
Intellij threw the following error for this syntax:
Non-static method 'toLowerCase(java.util.Locale)' cannot be referenced from a static context
I changed it to the current one. And updated the test cases. Shall I write new one for this change?
There was a problem hiding this comment.
You should write a failing test before you touch the code 🥲.
Do you want me to create this test case? |
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=========================================
Coverage 71.42% 71.42%
Complexity 386 386
=========================================
Files 48 48
Lines 1169 1169
Branches 101 101
=========================================
Hits 835 835
Misses 293 293
Partials 41 41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uhafner
requested changes
Jan 18, 2023
| @@ -132,7 +132,7 @@ public String toString() { | |||
|
|
|||
| private static int getDistinctCount(final Collection<? extends CommitDiffItem> commits, | |||
| final Function<CommitDiffItem, String> property) { | |||
| return (int) commits.stream().map(property).map(s -> String.toLowerCase(Locale.ENGLISH)).distinct().count(); | |||
There was a problem hiding this comment.
You should write a failing test before you touch the code 🥲.
src/main/java/io/jenkins/plugins/forensics/miner/CommitStatistics.java
Outdated
Show resolved
Hide resolved
Yes |
added 3 commits
January 19, 2023 11:55
uhafner
requested changes
Jan 19, 2023
src/test/java/io/jenkins/plugins/forensics/miner/CommitStatisticsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/forensics/miner/CommitStatisticsTest.java
Show resolved
Hide resolved
…icsTest.java Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
…/github.com/Jagrutiti/forensics-api-plugin into bug/make-email-insensitive-to-count-authors
uhafner
approved these changes
Jan 19, 2023
uhafner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated code to fix case sensitivity issue of email ids.
Jira id
https://issues.jenkins.io/browse/JENKINS-70239