[JENKINS-49377] Stop reading or writing BsiToken

[jglick]

JENKINS-49377

Would be better if the parent POM were updated to something newer, and then Jenkinsfile could

buildPlugin(jenkinsVersions: [null, '2.104'])

and have a JenkinsRule-based test which would do configRoundtrip on StaticAssessmentBuildStep, as that would most likely reproduce the error with the src/main/ changes temporarily reverted.

@reviewbybees esp. @oleg-nenashev

[oleg-nenashev]

@jglick Does it come from https://github.com/fortify/bsi-token-parser-kt/blob/419e6e4e1f9abedf1f4113d81cf1213251ca315c/src/main/kotlin/com/fortify/fod/parser/BsiToken.kt ?

[oleg-nenashev]

probably not required if you rename the field

[jglick]

Depends on whether you want to maintain compatibility with existing settings or not.

[jglick]

Actually I think you are right—both bsiToken and bsiTokenOriginal seem to have been added at the same time in #47 (which BTW offered no readResolve), so any instance with bsiToken should also bsiTokenOriginal.

[oleg-nenashev]

🐝 , I'd guess

[mtgibbs]

What's the concern here? If you don't save the token, the users settings are lost. I'm confused by the description of this PR.

[jglick]

If you don't save the token, the users settings are lost.

No they are not, because this plugin was already saving the String bsiTokenOriginal. It was just also saving this weird data structure with the same information (as of #47).

[oleg-nenashev]

PR build failed due to the INFRA issue from what I see.
CC @olblak

[olblak]

@oleg-nenashev Indeed ci.j.io had disk issue yesterday, it's working now

[mtgibbs]

Alright, I see the issue now. Thanks for the change on this to support 2.x. I'll get some testing done on this to make sure people don't have upgrade issues then publish with this fix in it.

[oleg-nenashev]

@mtgibbs Let me know once the fix is released. I will update https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200

[oleg-nenashev]

@mtgibbs gentler ping.

[oleg-nenashev]

@mtgibbs Jenkins LTS 2.107.1 will be released on March 14. Starting from this date we expects a significant number of users to start upgrading to the Jenkins versions with JEP-200

[mtgibbs]

Yeah, we just got our FoD release out last week, so this week I should be able to get this tested and published.

[mtgibbs]

@oleg-nenashev I've published @jglick 's fix today. You should be able to update the ticket. 3.0.8 should be the version containing the change.

[oleg-nenashev]

@mtgibbs sorry for the response delay. Thanks a lot for the release!