Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support triggering for wip-state-changed and private-state-changed #383
support triggering for wip-state-changed and private-state-changed #383
Changes from all commits
eaeec9e
ff01868
75cd209
c548261
139bf3e
abf91e4
fdc222d
e82bdce
a86412c
70a6d3a
126c7a6
71a1c3e
2fa5942
c018dec
1b647aa
2077f29
a84d5ad
37fc8b3
dcb307b
cae900e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By keep the original signature with deprecation I meant the original signature before you started making changes :)
We try to strive for keeping binary copatibility between releases of the plugin (since there is no clear way of indicating defined APIs)
And this change breaks binary compatibility because the signature
PluginPatchsetCreatedEvent(boolean, boolean)
is gone.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the misunderstanding, I should aware that.
If you still need me to change anything, just inform me.
Thanks for the patience.