Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69442] Defer query of change file paths until actually required #471

Merged

Conversation

chrisa-arm
Copy link
Contributor

The change based event payload includes enough information to
determine if the project, branch and topic match the configured
trigger definition. These should always be tested first before
checking any file path filters since that requires fetching the
list of files for the change from the Gerrit server.

This fix also removes unnecessary multiple loops over the file path
trigger filters for each branch filter. The branch and file path
filters in a given trigger definition are independent of each of other.

https://issues.jenkins.io/browse/JENKINS-69442

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The change based event payload includes enough information to
determine if the project, branch and topic match the configured
trigger definition. These should always be tested first before
checking any file path filters since that requires fetching the
list of files for the change from the Gerrit server.

This fix also removes unnecessary multiple loops over the file path
trigger filters for each branch filter. The branch and file path
filters in a given trigger definition are independent of each of other.
@chrisa-arm chrisa-arm force-pushed the JENKINS-69442-defer-file-paths-query branch from d9e58df to b5dd603 Compare August 25, 2022 15:56
@rsandell rsandell added the bug label Sep 16, 2022
@rsandell rsandell merged commit 97d63f0 into jenkinsci:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants