Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align docs with PLAIN matching #475

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

phoenikz
Copy link

@phoenikz phoenikz commented Oct 6, 2022

Documentation states that PLAIN matches with case sensitivity, but the implementation is with case insensitivity. This aligns documentation with implementation

Mutually exclusive with #474, proposing that maintainers select one and reject one - I have no opinion how it should work, just that is should be consistent

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ x] Ensure that the pull request title represents the desired changelog entry
  • [ x] Please describe what you did
  • [ x] Link to relevant issues in GitHub or Jira
  • [ x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Documentation states that PLAIN matches with case sensitivity, but the
implementation is with case insensitivity. This aligns documentation
with implementation
@rsandell rsandell merged commit d8a5bda into jenkinsci:master Oct 21, 2022
@rsandell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants