[JENKINS-72649] Add project parameter to SSH commands #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --project to the SSH review command calls so that it is possible to distinguish between conflicting change numbers within distinct projects. This change is backwards compatible to earlier versions of Gerrit, but becomes relevant both from optimization reasons since 2.15 and to prevent change collisions from 3.5 with the support for imported projects. Bug: Issue JENKINS-72649 Release-Notes: Add project parameter to SSH commands
rsandell
changed the title
rsandell
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --project to the SSH review command calls so that it is possible to distinguish between conflicting change numbers within distinct projects. This change is backwards compatible to earlier versions of Gerrit, but becomes relevant both from optimization reasons since 2.15 and to prevent change collisions from 3.5 with the support for imported projects.
Bug: Issue JENKINS-72649
Release-Notes: Add project parameter to SSH commands
Link: https://issues.jenkins.io/browse/JENKINS-72649
Testing done
All unit tests were run and are working. Integrated test with jenkins, applying default configuration to gerrit-trigger.xml and edits also functioning.
Unit test results:
...
[INFO] Running com.sonyericsson.hudson.plugins.gerrit.trigger.version.VersionCheckTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.139 s -- in com.sonyericsson.hudson.plugins.gerrit.trigger.version.VersionCheckTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Flakes:
[WARNING] com.sonyericsson.hudson.plugins.gerrit.trigger.dependency.IntegrationTest.testChildBuildSeeParametersOfParentJob
[ERROR] Run 1: IntegrationTest.testChildBuildSeeParametersOfParentJob:84->waitCompletedBuild:108 Timeout No build completed within 10s
[INFO] Run 2: PASS
[INFO]
[INFO]
[WARNING] Tests run: 601, Failures: 0, Errors: 0, Skipped: 1, Flakes: 1
[INFO]
[INFO]
[INFO] --- checkstyle:2.16:check (test-check) @ gerrit-trigger ---
[INFO] Starting audit...
Audit done.
Before:
After:
Tasks