Should fix [JENKINS-70162] [JENKINS-72193] [JENKINS-70539] [JENKINS-69338] Fix topic cancelling patches (this close races in abortBuild) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panicking
force-pushed
the
fix-topic-cancelling-patches
branch
4 times, most recently
from
6b957be
to
1177cf6
Compare
|
@rsandell For me is building but now it fails on CI, did not find any reason |
panicking
force-pushed
the
fix-topic-cancelling-patches
branch
2 times, most recently
from
50d78c2
to
7fb4ee8
Compare
The matching was working on a flat project organization. Jira-Id: JENKINS-70162 Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
If lot of patches are sent the removing on the queue is not working and job that must be aborted are not aborted. Suppose to have activated abortTopic and we want to push: patch A->B->C We would like that only the last patch is build and not B and A Jira-Id: JENKINS-70162 Jira-Id: JENKINS-72193 Jira-Id: JENKINS-71328 Jira-Id: JENKINS-70539 Jira-Id: JENKINS-69338 Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
panicking
force-pushed
the
fix-topic-cancelling-patches
branch
from
7fb4ee8
to
f410332
Compare
panicking
changed the title
|
Looks like the build was taking too long and got aborted. |
|
@rsandell Do you have time to review patches? Like the UI change and this one? I have already deployed both in two instance |
rsandell
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request fix bug connected of abort jobs coming from the same topic. What we try to get is the same behavior
of 2.36.1.
If we have a topic A->B->C we would like that the whole topic get built so build it from C. The problem was
that the jenkins try to build A , B and C for each new patcheset. There were mainly to problem:
Testing done
Create a project in gerrit, allow the project to be triggered and confirm that topic was really aborted