Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'merge method' support to the pull request merge action #476

Open
greggian opened this issue Jan 28, 2017 · 2 comments · May be fixed by #749
Open

Add 'merge method' support to the pull request merge action #476

greggian opened this issue Jan 28, 2017 · 2 comments · May be fixed by #749

Comments

@greggian
Copy link

It would be great to be able to control how a pull request is merged (squashed or rebased vs the default merge). The github api appears to have 'preview' support for this capability and the github-api library is also looking to add support for this (hub4j/github-api#326).

If/when the github-api library accepts the pull request, I think this feature would be a nice addition to this plugin.

Thanks for the great plugin!
@greggian
Copy link
Author

hub4j/github-api#326 has been merged and released as part of github-api v1.89. Also worth noting that merge method is now out of preview on the github api.

guillaume-eb added a commit to guillaume-eb/ghprb-plugin that referenced this issue Jul 10, 2019
@guillaume-eb
Add pull request merge method
495a05b 
for jenkinsci#476

this is supported by `github-api` since hub4j/github-api@ccfe3ad4f7
@guillaume-eb guillaume-eb linked a pull request Jul 10, 2019 that will close this issue
Open
@sai-tej
Copy link

sai-tej commented Aug 14, 2021

Hi, is there any plan to get this?
I have the same requirement and would be very helpful if it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pull request merge method guillaume-eb/ghprb-plugin
2 participants
@greggian @sai-tej