Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Builds On Update is not exposed via DSL #628

Closed
bsudy opened this issue Feb 12, 2018 · 3 comments
Closed

Cancel Builds On Update is not exposed via DSL #628

bsudy opened this issue Feb 12, 2018 · 3 comments

Comments

@bsudy
Copy link

bsudy commented Feb 12, 2018

I couldn't set 'Cancel Builds On Update' extension using DSL. As a solution I fall back to configure block using

configure { projectNode ->
    projectNode / 'triggers' / 'org.jenkinsci.plugins.ghprb.GhprbTrigger' / 'extensions' << 'org.jenkinsci.plugins.ghprb.extensions.build.GhprbCancelBuildsOnUpdate' {
        overrideGlobal(false)
    }
}

I think it would be great to have it also exposed in the DSL.

@bjoernhaeuser
Copy link
Contributor

@bsudy do you want to take the chance and contribute that change? :)

@bjoernhaeuser
Copy link
Contributor

I have a PR for this: #664

bjoernhaeuser added a commit that referenced this issue Jun 9, 2018
Expose cancelBuildsOnUpdate to dsl
nosmo pushed a commit to nosmo/ghprb-plugin that referenced this issue Dec 12, 2018
nosmo pushed a commit to nosmo/ghprb-plugin that referenced this issue Dec 12, 2018
@vfarafonov
Copy link

Just an FYI: PR for this was merged a long time ago but no release happened since then. Any plans to release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants