Fix credentials bugs as noted in jenkinsci/ghprb-plugin#117 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Actually use the new path generated as a fix in jenkinsci#122 - Use URIRequirementBuilder instead of manually building a requirements list - Add logging around accessing credentials to debug failures, and give better error messages when something is wrong - General refactoring of a few methods to reduce code duplication
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I will check this out tomorrow night, and see if i can release it then |
|
Could you please take a look at this ASAP? Half of GHPRB isn't working because of this problem when OAuth credentials are used. |
DavidTanner
added a commit
that referenced
this pull request
Jun 29, 2015
Fix credentials bugs as noted in #117
|
could you cut a release as well? |
|
released as 1.24.4 |
|
Thanks so much, you're awesome! |
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Fix credentials bugs as noted in jenkinsci#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for fixing credentials issues #122
list
better error messages when something is wrong
I've tested this on my Jenkins instance, and it seems to fix the issues I addressed, as well as providing helpful debugging messages in the logs.
It seems that anonymous requests are still occasionally being used; I'm not sure if the github-api library is occasionally falling back on failures.
Fully fixes #117.