Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iterating through downstream builds (if present) to compose the message that will be posted to Github #48

Merged
merged 48 commits into from
Sep 15, 2014
Merged

Support iterating through downstream builds (if present) to compose the message that will be posted to Github #48

merged 48 commits into from
Sep 15, 2014

Conversation

mdelapenya
Copy link
Contributor

No description provided.

@cloudbees-pull-request-builder
Copy link

plugins » ghprb-plugin #170 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@DavidTanner
Copy link
Contributor

@mdelapenya It would be great if you could add some tests to this to verify that it works, and doesn't get broken by any changes made in the future. I am not familiar with these kind of builds, and so I am hoping that we can get some reviews by someone else.

@mdelapenya
Copy link
Contributor Author

Of course @DavidTanner, I'll work on those tests as soon as possible.

Thanks!

@mdelapenya
Add build-flow plugin as dependency
e7c3540
@mdelapenya
Extract buildURL calculation to a method
f629383
@mdelapenya
If build is from FlowRun type, then iterate through its jobs graph ad…
0ef710d 
…ding all downstream jobs build urls to the message that will be posted to github pull request.
@mdelapenya
Make build-flow dependency optional, as suggested
983d35f
@mdelapenya
Define an interface to calculate build URL, implementing a default be…
137b72f 
…haviour
@mdelapenya
Implement BuildFlow build url calculation
814c1b7
@mdelapenya
Use a factory to decide which downstream manager to use
b52fd3f
@mdelapenya
Apply factory to the place where URL is calculated to be sent to github
a3f550e
@mdelapenya
Prevent that the plugin is not installed, returning default behaviour…
7dc1790 
… instead
@mdelapenya
Forgot author
287165c
@mdelapenya
Add javadocs
ae61ba2
@mdelapenya
Rename classes with better names
7e53539
@mdelapenya
Create a flag on plugin configuration to display -or not- build error…
e37d094 
…s directly on the github pull request
@mdelapenya
Rename method to be more generic
57d076f
@mdelapenya
Only append message if the build result is success OR display build e…
c839f2e 
…rrors on downstream builds is enabled
@mdelapenya
Generate the customized message only for two conditions: the build re…
78389c0 
…sult is success OR the display build errors on downstream builds is enabled
@mdelapenya
Rename interface and base class, as they will be managing downstream …
f55314a 
…builds, not only the URLs on them
@mdelapenya
Support retrieving the downstream builds as an iterator, so it could …
5671407 
…be used to see tests results
@mdelapenya
Support retrieving testName&since attributes from downstream tests re…
d36dfc0 
…sult
@mdelapenya
Add stacktrace to the output message
72c7b1d
@mdelapenya
Print stacktrace inside code block
5034180
@mdelapenya
Return a set with uniques nodes, as JobEdge iterator retrieves all no…
1ec50a9 
…des with connections
@mdelapenya
Update tests
6b6f5cf
@mdelapenya
Forgot to add message if conditions are not satisfied
f3047c5
@mdelapenya
This logic is better to determine which message to append
1c67640
@mdelapenya
Print stack traces only when configured
02053c6
alee8888 and others added 22 commits September 4, 2014 11:50
@alee8888 @mdelapenya
Print the total number of failures
8578bb6
@mdelapenya
Display failed test count in the H2, using github's css class for fai…
e95be40 
…lures (red)
@mdelapenya
Prepend build url to failed test url
e09658c
@mdelapenya
Always append downstream build, and only tests results when build res…
4a26cd5 
…ult is not success
@mdelapenya
More readable condition
e15ba2e
@mdelapenya
Rename the method to retrieve the downstream projects
66bfed9
@mdelapenya
Use a logger instead of printing the stacktrace
9c8aa48
@mdelapenya
Simpler way to retrieve the vertex of the graph flow
2cc9ba3
@mdelapenya
Proper package naming
39aa6f7
@mdelapenya
Do not use deprecated code (http://javadoc.jenkins-ci.org/hudson/mode…
ac0c063 
…l/AbstractBuild.html#getAggregatedTestResultAction%28%29)
@mdelapenya
Use the same URL for failed tests as jUnit plugin
d946efa
@mdelapenya
Add fail fast conditions
3615f61
@mdelapenya
Use an anchor to display downstream build url
39dc2e8
@mdelapenya
Tests: Support creating BuildFlow projects using a TestRule
45e3674
@mdelapenya
Tests: add tests to verify that GhprbBuildManager returns the proper …
7b2aa1b 
…instance
@mdelapenya
Fix potential NPE discovered by test
e862423
@mdelapenya
Move utility methods to a utility class, to reuse methods across tests
8373368
@mdelapenya
Define a base test class so that we could reuse methods on different …
f0fbaac 
…test classes
@mdelapenya
Add tests for url calculation using default implementation
37768b0
@mdelapenya
Add tests for BuildFlow job configuration
ef22983
@mdelapenya
Add test for BuildFlow manager
3ba378d
@mdelapenya
Improve fail fast conditions, appending last 25 build log lines
244b60b
@mdelapenya
Copy link
Contributor Author

Hey @DavidTanner I've added some tests for the build flow plugin functionality

I hope they help you in reviewing it :)

Thanks!

DavidTanner pushed a commit that referenced this pull request Sep 15, 2014
Merge PR #48
d914843
@DavidTanner DavidTanner merged commit 244b60b into jenkinsci:master Sep 15, 2014
DavidTanner pushed a commit that referenced this pull request Sep 15, 2014
mering PR #48
074032f
@mdelapenya mdelapenya deleted the support-downstream-builds branch September 16, 2014 06:20
nosmo pushed a commit to nosmo/ghprb-plugin that referenced this pull request Dec 12, 2018
mering PR jenkinsci#48
eb10d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mdelapenya @cloudbees-pull-request-builder @jenkinsadmin @DavidTanner @alee8888