Cancel downstream builds if was triggered by GHPRB. #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the situation where a build trigger a new async builds, if any user updates the PR only one build will be cancel, the upstream one. When downstreams jobs take a lot to run, the CI is block with builds taht does not make sense to have running at all. With this change, each build is validated if the cause is a `UpstreamCause` and if it is true, this validates that the parent build was triggered by GHPRB, if so will be cancel if the PR id match. Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the situation where a build trigger a new async builds, if any user updates
the PR only one build will be cancel, the upstream one.
When downstreams jobs take a lot to run, the CI is block with builds taht does
not make sense to have running at all.
With this change, each build is validated if the cause is a
UpstreamCauseandif it is true, this validates that the parent build was triggered by GHPRB, if
so will be cancel if the PR id match.
I didn't found where the CancelOnUpdates is tested, I'm happy to add a test,
but I would need a bit of help.
I'm not sure about adding things to Changelog, the version in Changelog in
1.41, but releases in Github is 1.42, happy to update also that, but need
some insights.