Add @issue annotations to CredentialsTest

Reduce CredentialsTest differences between stable-2.7 and master branch
jenkinsci · Aug 1, 2018 · f062e58 · f062e58
1 parent 58a254d
commit f062e58
Showing 1 changed file with 7 additions and 21 deletions.
diff --git a/src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java b/src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
@@ -42,6 +42,7 @@
 import org.junit.rules.TemporaryFolder;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
+import org.jvnet.hudson.test.Issue;
 import org.jvnet.hudson.test.JenkinsRule;
 import org.json.simple.JSONObject;
 import org.json.simple.JSONArray;
@@ -353,6 +354,7 @@ private boolean testPeriodNotExpired() {
     }
 
     @Test
+    @Issue("JENKINS_50573")
     public void testFetchWithCredentials() throws URISyntaxException, GitException, InterruptedException, MalformedURLException, IOException {
         assumeTrue(testPeriodNotExpired());
         File clonedFile = new File(repo, fileToCheck);
@@ -402,27 +404,11 @@ public void testRemoteReferencesWithCredentials() throws Exception {
         assertThat(remoteReferences.keySet(), hasItems("refs/heads/master"));
     }
 
-    private String show(String name, String value) {
-        if (value != null && !value.isEmpty()) {
-            return " " + name + ": '" + value + "'";
-        }
-        return "";
-    }
-
-    private String show(String name, File file) {
-        if (file != null) {
-            String homePath = HOME_DIR.getAbsolutePath();
-            String filePath = file.getAbsolutePath();
-            if (filePath.startsWith(homePath)) {
-                filePath = filePath.replace(homePath, "~");
-            }
-            return " " + name + ": '" + filePath + "'";
-        }
-        return "";
-    }
-
-    private String show(String name, char value) {
-        return " " + name + ": '" + value + "'";
+    @Test
+    @Issue("JENKINS_50573")
+    public void isURIishRemote() throws Exception {
+        URIish uri = new URIish(gitRepoURL);
+        assertTrue("Should be remote but isn't: " + uri, uri.isRemote());
     }
 
     private boolean isWindows() {