Fix JENKINS-30371 allow symlinks with jgit #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGit symlink support is optional with JGit 3.7.1. It requires a copy of the JGit java7 jar, a Java 7 VM, and a file system which supports symbolic links. Including the jar file in a Java 6 environment is safe because the JGit code won't load the additional jar when running on Java 6.
Latest findbugs requires Java 7, but the git client plugin needs to allow testing with Java 6 so that Java 6 users are not broken by changes.
MarkEWaite
added a commit
that referenced
this pull request
Nov 23, 2015
…links [Fix JENKINS-30371] allow symlinks with jgit
| @@ -2044,13 +2044,20 @@ public void test_hasSubmodules() throws Exception { | |||
| assertFalse(w.git.hasGitModules()); | |||
| } | |||
|
|
|||
| private boolean isJava6() { | |||
| if (System.getProperty("java.version").startsWith("1.6")) { | |||
There was a problem hiding this comment.
Yes, as is 1.6.0_0 and 1.6.0_14 and 1.6.0_11 and 1.6.0_15 and 1.6.0_05 and 1.6.0_45. The question is trying to answer "is this Java 6 (and not Java 7 or Java 8)", not "is this a specific version of Java 6".
Do you see a problem with that technique?
Is there a better technique for deciding that the currently executing Java runtime environment does not have support for symbolic links?
There was a problem hiding this comment.
startsWith("1.6.") looks better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including one more JGit jar from the JGit 3.7.1 package allows JGit to support symbolic links in some cases.
Users running Java 6 will not have symlink support because the JGit library won't be loaded.
Users running Windows with default settings will not have symlink support because Windows does not allow symbolic links by default.
Users running Linux or FreeBSD or HP-UX or AIX or other Unix-like environments should have symbolic link support so long as they are running Java 7 or newer.