Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-21016] Remove credential section as helper is a property within the credential section. #47

Merged
merged 6 commits into from Dec 20, 2013

Conversation

pphillips-techphob
Copy link
Contributor

[JENKINS-21016] correct remove-section. The section is called credential rather than credential.helper e.g.:

C:\Users\test>git config --local --list
credential.helper=store --file="c:\creden.txt"

C:\Users\test>git config --local --remove-section credential.helper
fatal: No such section!

C:\Users\test>git config --local --remove-section credential

C:\Users\test>git config --local --list

…shes, so revert. More importantly need the credentials on a single line so that the git command can read successfully
…nd up with multiple [credential] sections, or worse, multiple credential.helper rows
Conflicts:
	src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
…al helper. Remove the whole section as using unset to remove credential.helper caused a new credential section to appear on the next set
@cloudbees-pull-request-builder

plugins » git-client-plugin #194 SUCCESS
This pull request looks good

ndeloof added a commit that referenced this pull request Dec 20, 2013
[JENKINS-21016] Remove credential section as helper is a property within the credential section.
@ndeloof ndeloof merged commit 79c0e19 into jenkinsci:master Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants