Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-23477] expand vars in sparse checkout field #508

Merged
merged 2 commits into from Dec 2, 2022

Conversation

yashj21
Copy link
Contributor

@yashj21 yashj21 commented Feb 14, 2020

JENKINS-23477 git plugin sparse checkout path field does not expand environment variables

Made a bug fix to expand all the sparse checkout paths using the environment variable just before the git command line execution

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@MarkEWaite MarkEWaite changed the title JENKINS-23477:git plugin sparse checkout path field does not expand v… [JENKINS-23477] git plugin sparse checkout field does not expand vars Feb 14, 2020
@MarkEWaite MarkEWaite changed the title [JENKINS-23477] git plugin sparse checkout field does not expand vars [JENKINS-23477] expand vars in sparse checkout field Feb 14, 2020
@toutiyeti
Copy link

Hello @MarkEWaite , is it possible to include this change in the next release ? We are waiting for this since 5 years :)
Thanks ! Bye

@philipleetaylor
Copy link

Hello @MarkEWaite - voting/promoting to please get this released.

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Nov 9, 2022

Hello @MarkEWaite - voting/promoting to please get this released.

You can use it now, without waiting for a release and then when you have confirmed it is working for you, you can post the results of your use here. Download the hpi file from https://ci.jenkins.io/job/Plugins/job/git-client-plugin/job/PR-508/lastSuccessfulBuild/ and upload it to your Jenkins controller.

@MarkEWaite MarkEWaite merged commit d42bda9 into jenkinsci:master Dec 2, 2022
@MarkEWaite MarkEWaite added bug Incorrect or flawed behavior and removed bugfix labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or flawed behavior
Projects
None yet
5 participants