Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows test failure by enabling core.longpaths #595

Conversation

MarkEWaite
Copy link
Contributor

Fix Windows test failure by enabling core.longpaths

One of the submodule cloning tests, testSubmodulesUsedFromOtherBranches, fails on Windows agents when the Windows workspace is in the default location on a Windows master.

Rather than fight with that directory location, enable core.longpaths for the failing test. Eventually we'll want to enable core.longpaths on all command line git use from Windows computers.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

One of the submodule cloning tests,
testSubmodulesUsedFromOtherBranches, fails on Windows agents when the
Windows workspace is in the default location on a Windows master.

Rather than fight with that directory location, enable core.longpaths
for the failing test.  Eventually we'll want to enable core.longpaths
on all command line git use from Windows computers.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Aug 8, 2020
@MarkEWaite MarkEWaite merged commit c340547 into jenkinsci:master Aug 8, 2020
@MarkEWaite MarkEWaite deleted the fix-long-path-failure-in-submodule-test branch August 8, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
1 participant