Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases related to JENKINS-21434 - alternates file wrong content #77

Merged

Conversation

MarkEWaite
Copy link
Contributor

Checks that cloned copies have the alternates file with expected
content when the clone is performed with a reference repository, and
that cloned copies do not have the alternates file when clone does not
use a reference repository.

Checks that cloned copies have the alternates file with expected
content when the clone is performed with a reference repository, and
that cloned copies do not have the alternates file when clone does not
use a reference repository.
@cloudbees-pull-request-builder

plugins » git-client-plugin #246 SUCCESS
This pull request looks good

ndeloof added a commit that referenced this pull request Jan 21, 2014
Test cases related to JENKINS-21434 - alternates file wrong content
@ndeloof ndeloof merged commit dc35b60 into jenkinsci:master Jan 21, 2014
@ndeloof
Copy link
Contributor

ndeloof commented Jan 21, 2014

Would be even better to check if the clone repository has the expected commits based on reference

@MarkEWaite
Copy link
Contributor Author

Good idea. I'll consider that for a future submission. My first attempt to write a test that checked for the correct submissions was a failure. It did not detect what I wanted, so I revised the test to a minimal check, confirm the contents of the alternates file are correct.

@MarkEWaite MarkEWaite deleted the master-test-JENKINS-21434-fixed branch January 21, 2014 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants