Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to new default branch name #789

Merged
merged 6 commits into from Dec 24, 2021

Conversation

MarkEWaite
Copy link
Contributor

JENKINS-67362- Test with init.defaultBranch value

  • JENKINS-67362 Test with init.defaultBranch value
  • Ignore VSCode working files
  • Log GitTool redundant initialization
  • Use spotless to remove unused imports
  • Remove unused variables in tests
  • Return a typed collection in test

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Test improvement

@github-actions github-actions bot added the test Automated test addition or improvement label Dec 24, 2021
Also assures each file ends with a newline
Previous technique was only checking for the setting at global level for
the user and was ignoring system level configuration.  Git for Windows
provides an installation option that configures it at the system level.

If the defaultBranch name is set at any level, honor that setting.
@MarkEWaite MarkEWaite merged commit a1f50ff into jenkinsci:master Dec 24, 2021
@MarkEWaite MarkEWaite deleted the adapt-to-git-main-branch branch December 24, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
1 participant