Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46119] Use the job name in context string #153

Closed
wants to merge 1 commit into from

Conversation

dubrsl
Copy link

@dubrsl dubrsl commented Aug 10, 2017

No description provided.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do this. There was an issue specifically requesting that the context string not include details like a job name, and that was fixed. The reason is that GitHub has features whereby you can control various workflows by specifying approved status context strings, and they need to be an exact match.

@dubrsl
Copy link
Author

dubrsl commented Aug 15, 2017

Different approaches require different settings. IMHO context should be configurable with defaults like now.

@stephenc
Copy link
Member

This should be handled using traits to control the naming behaviour.

As such I recommend splitting this into a PR on this repo that enabled a trait to configure the notification context naming by decorating the GitHubSCMSourceContext / Request and then a new separate extension plugin that provides the trait with the new behaviour.

Closing this PR not as a rejection of the principle of the change but as a rejection of the chosen implementation strategy

@stephenc stephenc closed this Aug 29, 2017
@Puneeth-n
Copy link

Is there a way to set a configurable context?

@fho
Copy link

fho commented Oct 23, 2018

I also also need a way to set the shown status to something more descriptive.
If you have multiple multibranch Jenkins jobs running you end up with multiple 'continuous-integration/jenkins/' statuses and you have no clue what was successful or what failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants