fix(discover branches): keep "PR branches" option #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is in response to the branch-discovery help text: " Only branches that are also filed as PRs This option exists to preserve legacy behaviour when upgrading from older versions of the plugin. NOTE: If you have an actual use case for this option please file a pull request against this text. " We have a Jenkins pipeline that deploys dockers for pull requests to a k8s cluster. The Dockers are built by a separate process, and tagged with the branch name, so we want our k8s-deploy pipeline to be fed the PR branch name in env.GIT_BRANCH, so it can reference the appropriate docker. Hope that makes sense.
|
@frickjack this is so much clearer! could you change the title of this PR to indicate it's just a documentation change? |
stephenc
reviewed
Dec 21, 2017
| @@ -8,8 +8,8 @@ | |||
| </dd> | |||
| <dt>Only branches that are also filed as PRs</dt> | |||
| <dd> | |||
| This option exists to preserve legacy behaviour when upgrading from older versions of the plugin. | |||
| NOTE: If you have an actual use case for this option please file a pull request against this text. | |||
| Similar to discovering pull requests directly, but env.GIT_BRANCH is set to the branch name rather than PR-#, | |||
There was a problem hiding this comment.
Clarify that it is just origin pull requests.
| This option exists to preserve legacy behaviour when upgrading from older versions of the plugin. | ||
| NOTE: If you have an actual use case for this option please file a pull request against this text. | ||
| Similar to discovering pull requests directly, but env.GIT_BRANCH is set to the branch name rather than PR-#, | ||
| and github pull-request checks are not updated. |
There was a problem hiding this comment.
I think it would be better to reword as something like “the status notification for the build will only be applied to the commit, the pull requests status will not be updated” (my text needs revision, but should point you in the direction more clearly
|
@frickjack @stephenc |
|
The PR is still valid but I think my comments also still need addressing |
stephenc
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the branch-discovery help text:
"
Only branches that are also filed as PRs
This option exists to preserve legacy behaviour
when upgrading from older versions of the plugin.
NOTE: If you have an actual use case for this option
please file a pull request against this text.
"
We have a Jenkins pipeline that deploys dockers for
pull requests to a k8s cluster. The Dockers are
built by a separate process, and tagged with the
branch name, so we want our k8s-deploy pipeline
to be fed the PR branch name in env.GIT_BRANCH,
so it can reference the appropriate docker.
Hope that makes sense.