AbstractGitHubNotificationStrategy is not an ExtensionPoint #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops! I had no idea what I was doing. I mean, I still don't, but yeah. Thanks for the cleanup. |
|
Not a problem at all, just something I noticed while trying to read through sources in this plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #162. An
ExtensionPointis an interface you could implement as a singleton and apply an@Extensionto. (Traditionally it is also used onDescribables, though technically the actual extension point is the correspondingDescriptor.) https://github.com/jenkinsci/github-scm-trait-notification-context-plugin/blob/f5cb5c1a32fc6da2775d6791285d5a5901dbee8a/src/main/java/org/jenkinsci/plugins/githubScmTraitNotificationContext/NotificationContextTrait.java#L51-L76 confirms that the actual extension point here remains theSCMSourceTrait[Descriptor].