Switch to SVGs for most icons #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Feb 21, 2021
timja
commented
Feb 21, 2021
| @@ -1585,54 +1586,54 @@ public boolean test(SCMTraitDescriptor<?> scmTraitDescriptor) { | |||
|
|
|||
| IconSet.icons.addIcon( | |||
| new Icon("icon-github-logo icon-sm", | |||
| "plugin/github-branch-source/images/16x16/github-logo.png", | |||
| Icon.ICON_SMALL_STYLE)); | |||
| "plugin/github-branch-source/images/svgs/sprite-github.svg#github-logo", | |||
There was a problem hiding this comment.
I've left the old github-logo image file in as it's used here:
I'm not aware of a way to trigger that code though
There was a problem hiding this comment.
Could we return the same SVG regardless of size value?
There was a problem hiding this comment.
Yes we can, I'm just wary of touching UI code I can't test.
My point was I don't know if this code is possible to hit, at least on github.com
10 tasks
|
This looks good to me. |
timja
commented
Apr 6, 2021
timja
commented
Apr 6, 2021
|
@timja What are we waiting on here? |
|
nothing |
bitwiseman
approved these changes
Apr 19, 2021
|
@bitwiseman can this get re-released please? |
|
@timja Updating to use the 2.289.x LTS. This means we now have three release lines. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A brief summary describing the changes in this pull request. See
JENKINS-XXXXX for further information.
Light branch
Dark branch
Light repo
Dark repo
Light github logo
Dark github logo
Fixes jenkinsci/dark-theme-plugin#104
Requires jenkinsci/jenkins#5065
I've left the scm navigator icon alone, it's only used on the new job page as far as I could tell, I didn't think any of the icons I found were a good fit
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify
@bitwiseman @dwnusbaum @fqueiruga