Add the status checks property to allow publishing unstable builds as neutral checks #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
============================================
+ Coverage 82.37% 82.81% +0.43%
- Complexity 148 154 +6
============================================
Files 13 13
Lines 437 448 +11
Branches 41 41
============================================
+ Hits 360 371 +11
Misses 61 61
Partials 16 16
Continue to review full report at Codecov.
|
timja
reviewed
Feb 9, 2021
| @@ -1,13 +1,7 @@ | |||
| <?jelly escape-by-default='true'?> | |||
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form"> | |||
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:i="/io/jenkins/plugins/checks/github/status"> | |||
There was a problem hiding this comment.
this is the convention normally used
Suggested change
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:i="/io/jenkins/plugins/checks/github/status"> | |
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:g="/lib/github-checks/status"> |
There was a problem hiding this comment.
you mean I'll need to create new folders specifically to include these lib files?
timja
approved these changes
Feb 9, 2021
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
timja
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: jenkinsci/checks-api-plugin#46